Code Ruler Review

I am assigned to review Marcius and Ka Yee’s code. Their code does not have many violations of the Java standard, and I am a little surprised that they are actually using the two spaces indentation. Here is a table of the violation of their code:

File	Lines	Violation	Comments
MyRuler.java	92,152,158, *	EJS-76	The “if” should always has curly brace
MyRuler.java	106,136	EJS-5	The “else if” should be on the next line
MyRuler.java	124	EJS-61	Avoid the use of end-line comment
MyRuler.java	9,149	EJS-6	Comment longer than 100 characters
MyRuler.java	79,97,129	ICS-SE-JAVA-9	Prefer using for/in structure

I like the idea how they split up the knights into two groups, which is similar to the built-in split up ruler. Also from the result of their testing, it seems this strategy has worked quite nicely against the built-in ruler. Overall this is a nicely written code.